-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unbind integer textures #7273
Unbind integer textures #7273
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #7273 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 699 699
=========================================
Hits 699 699 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll defer to someone else (@GoodBoyDigital) for the functionality here, but code quality looks fine. Just a few minor comments.
And welcome back @ivanpopelyshev glad to see PRs from you again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good addition! We should add it to PixiJS Examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Hey guys, seems like something from @ivanpopelyshev's fix is missing. Using v6.0.2 I am still unable to render integer textures along with float textures. v6.0.2: https://www.pixiplayground.com/#/edit/hMVY0qgOa6lLoNTi_PnEX <-- Not working |
That's my fault. Looks like it never actually got cherry-picked to 6.0.2. Will make sure it's 6.0.3. |
All sample types in shaders can have
u
ori
prefix:usampler2D
,isamplerCube
I added those types in
SAMPLER_TYPES
. To ensure that batcher doesn't use sampler of wrong type, and drawcall doesnt crash, TextureSystem unbinds those kind of textures.Problem: https://www.html5gamedevs.com/topic/46983-mesh-graphics-render-issue/
Spawns error in console: https://www.pixiplayground.com/#/edit/xpLx-ElnpPPPXFJUkxoRa
Doesnt spawn errors: https://www.pixiplayground.com/#/edit/xpLx-ElnpPPPXFJUkxoRa
This PR conflicts with #7222 in
afterEach
thingy