Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spritesheet dependency from loader, fix resources type #7300

Merged
merged 2 commits into from
Mar 17, 2021

Conversation

bigtimebuddy
Copy link
Member

@bigtimebuddy bigtimebuddy commented Mar 16, 2021

Replaces #7295

  • Remove the @pixi/spritesheet dependency from @pixi/loaders
  • Fix the resources type for Loader to be more strict (e.g., contains texture) credit: @AdrienLemaire
  • Added some additional documentation for Loader interfaces

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #7300 (f2e1363) into dev (f6d9404) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #7300   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          699       699           
=========================================
  Hits           699       699           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6d9404...9c061f5. Read the comment docs.

@ShukantPal
Copy link
Member

ShukantPal commented Mar 16, 2021 via email

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Mar 16, 2021
@bigtimebuddy
Copy link
Member Author

Understood on webdoc @SukantPal With these mixins we will probably need to add both global docs (for TS tooltips) and src docs (for webdoc).

@bigtimebuddy bigtimebuddy merged commit ee8b4c1 into dev Mar 17, 2021
@bigtimebuddy bigtimebuddy deleted the fix-loader-types branch March 17, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants