Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Internal Format Constants for Compressed Textures #7338

Merged
merged 1 commit into from
Mar 27, 2021
Merged

Fix Internal Format Constants for Compressed Textures #7338

merged 1 commit into from
Mar 27, 2021

Conversation

bigtimebuddy
Copy link
Member

@bigtimebuddy bigtimebuddy added this to the v6.0.2 milestone Mar 25, 2021
@codecov
Copy link

codecov bot commented Mar 25, 2021 •
edited

Codecov Report

Merging #7338 (85c773f) into dev (984510c) will not change coverage.
The diff coverage is n/a.

❗ Current head 85c773f differs from pull request most recent head 8a9c0cc. Consider uploading reports for the commit 8a9c0cc to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #7338   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          699       699           
=========================================
  Hits           699       699

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 984510c...8a9c0cc. Read the comment docs.

hdemmer
hdemmer approved these changes Mar 26, 2021
View reviewed changes
Copy link

@hdemmer hdemmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Mar 27, 2021
@bigtimebuddy bigtimebuddy merged commit 99641dc into dev Mar 27, 2021
@bigtimebuddy bigtimebuddy deleted the fix-7330 branch March 27, 2021 23:09
bigtimebuddy added a commit that referenced this pull request Mar 27, 2021
@bigtimebuddy
Fix internal format constants for compressed textures (#7338)
8130a10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpopelyshev ivanpopelyshev ivanpopelyshev approved these changes

@hdemmer hdemmer hdemmer approved these changes

@ShukantPal ShukantPal ShukantPal approved these changes

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
v6.0.2
Development

Successfully merging this pull request may close these issues.

Black RGBA8_ETC2 compressed textures on device due to wrong magic values
4 participants
@bigtimebuddy @ivanpopelyshev @hdemmer @ShukantPal