Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FXAA filter #7406

Merged
merged 2 commits into from
May 4, 2021
Merged

Fix FXAA filter #7406

merged 2 commits into from
May 4, 2021

Conversation

dev7355608
Copy link
Collaborator

The FXAA filter uses inputPixel when it should use inputSize. Here is an example that shows how it fails when the resolution is something other than 1.

Pre-Merge Checklist
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@bigtimebuddy bigtimebuddy added this to the v6.0.3 milestone Apr 14, 2021
@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label May 4, 2021
ShukantPal
ShukantPal approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@ShukantPal ShukantPal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@bigtimebuddy bigtimebuddy merged commit 0f932be into pixijs:dev May 4, 2021
@bigtimebuddy
Copy link
Member

Thanks @dev7355608 another great PR 👍

bigtimebuddy pushed a commit that referenced this pull request May 4, 2021
@dev7355608 @bigtimebuddy
Fix FXAA filter (#7406)
7e3ef4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpopelyshev ivanpopelyshev ivanpopelyshev approved these changes

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

@ShukantPal ShukantPal ShukantPal approved these changes

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
v6.0.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dev7355608 @bigtimebuddy @ivanpopelyshev @ShukantPal