Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update URL_Filters Demo #7408

Merged
merged 2 commits into from
Apr 16, 2021
Merged

Update URL_Filters Demo #7408

merged 2 commits into from
Apr 16, 2021

Conversation

ghsable
Copy link
Contributor

@ghsable ghsable commented Apr 15, 2021 •
edited

Description of change
  • README.md: Update URL(Filters Demo)
    • http://pixijs.io/pixi-filters/tools/demo/ -> https://filters.pixijs.download/v3.2.0/demo/index.html
Pre-Merge Checklist
  • Tests and/or benchmarks are included
  • Documentation is changed or added
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@bigtimebuddy
Copy link
Member

bigtimebuddy commented Apr 15, 2021 •
edited

Should actually be https://pixijs.io/filters/tools/demo

Edit: Updated, thanks for pointing this one out!

bigtimebuddy
bigtimebuddy reviewed Apr 15, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@bigtimebuddy bigtimebuddy added this to the v6.0.3 milestone Apr 15, 2021
ShukantPal
ShukantPal approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@ShukantPal ShukantPal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to update the description when the value changes in the code.

@ShukantPal ShukantPal added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Apr 16, 2021
@bigtimebuddy bigtimebuddy merged commit 5264e44 into pixijs:dev Apr 16, 2021
@bigtimebuddy
Copy link
Member

Thanks @ghsable 🎉

bigtimebuddy pushed a commit that referenced this pull request Apr 16, 2021
@ghsable @bigtimebuddy
Update Filters Demo link on README (#7408)
188bfbc
@ghsable
Copy link
Contributor Author

ghsable commented Apr 16, 2021

Thanks 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

@ShukantPal ShukantPal ShukantPal approved these changes

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
v6.0.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ghsable @bigtimebuddy @ShukantPal