Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore original alpha value for cacheAsBitmap #7433

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

eXponenta
Copy link
Contributor

@eXponenta eXponenta commented Apr 21, 2021

Restore original alpha value of cached node, otherwith we corrupt node state and alpha will be missed while not changed outside after first calling a _initCachedDisplayObject
Fix #7432

Description of change
Pre-Merge Checklist
  • Tests and/or benchmarks are included
  • Documentation is changed or added
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

Restore original alpha value of cached node, otherwith we corrupt node state and alpha will be missed while not changed outside after first calling a  `_initCachedDisplayObject`
Fix pixijs#7432
@eXponenta eXponenta changed the title fix: Restore original alpha value fix: Restore original alpha value for cacheAsBitmap Apr 21, 2021
Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one

@bigtimebuddy bigtimebuddy added this to the v6.0.3 milestone Apr 21, 2021
@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Apr 21, 2021
@bigtimebuddy bigtimebuddy merged commit f91ee68 into pixijs:dev Apr 27, 2021
@bigtimebuddy
Copy link
Member

Good fix, thank you @eXponenta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CacheAsBitmap resetting alpha to 1 after render
3 participants