Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make getChildByName non-optional #7451

Merged
merged 1 commit into from
May 4, 2021
Merged

Make getChildByName non-optional #7451

merged 1 commit into from
May 4, 2021

Conversation

ShukantPal
Copy link
Member

Fixes #7444

@ShukantPal ShukantPal requested review from a team and bigtimebuddy April 24, 2021 21:12
@codecov
Copy link

codecov bot commented Apr 24, 2021

Codecov Report

Merging #7451 (d26f4e6) into dev (8c42699) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #7451   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          699       699           
=========================================
  Hits           699       699

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c42699...d26f4e6. Read the comment docs.

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Apr 29, 2021
@bigtimebuddy bigtimebuddy added this to the v6.0.3 milestone Apr 29, 2021
@bigtimebuddy bigtimebuddy mentioned this pull request Apr 30, 2021
Merged
@bigtimebuddy bigtimebuddy merged commit ddd7464 into dev May 4, 2021
@bigtimebuddy bigtimebuddy deleted the fix/name-mixin-typings branch May 4, 2021 20:31
bigtimebuddy pushed a commit that referenced this pull request May 4, 2021
@ShukantPal @bigtimebuddy
Make getChildByName non-optional (#7451)
19fca9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpopelyshev ivanpopelyshev ivanpopelyshev approved these changes

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

@Zyie Zyie Zyie approved these changes

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
v6.0.3
Development

Successfully merging this pull request may close these issues.

getChildByName is set as optional in v6
4 participants
@ShukantPal @ivanpopelyshev @bigtimebuddy @Zyie