Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes TilingSprite.from usage with a Texture parameter #7471

Merged
merged 2 commits into from
May 6, 2021
Merged

Fixes TilingSprite.from usage with a Texture parameter #7471

merged 2 commits into from
May 6, 2021

Conversation

bigtimebuddy
Copy link
Member

Fixes #7469

@bigtimebuddy bigtimebuddy added this to the v6.0.3 milestone May 5, 2021
@codecov
Copy link

codecov bot commented May 5, 2021 •
edited

Codecov Report

Merging #7471 (3950001) into dev (e24516e) will not change coverage.
The diff coverage is n/a.

❗ Current head 3950001 differs from pull request most recent head d53d67a. Consider uploading reports for the commit d53d67a to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #7471   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          699       699           
=========================================
  Hits           699       699

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e24516e...d53d67a. Read the comment docs.

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label May 6, 2021
@bigtimebuddy bigtimebuddy merged commit ccf75ae into dev May 6, 2021
@bigtimebuddy bigtimebuddy deleted the fix-7469 branch May 6, 2021 16:35
bigtimebuddy added a commit that referenced this pull request May 6, 2021
@bigtimebuddy
Fix TilingSprite.from usage with a Texture parameter (#7471)
9843e15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpopelyshev ivanpopelyshev ivanpopelyshev approved these changes

@ShukantPal ShukantPal ShukantPal approved these changes

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
v6.0.3
Development

Successfully merging this pull request may close these issues.

PIXI.TilingSprite.from throws error when using existing Texture as source
3 participants
@bigtimebuddy @ivanpopelyshev @ShukantPal