Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enabled property to MaskData #7653

Merged
merged 4 commits into from
Sep 13, 2021
Merged

Add enabled property to MaskData #7653

merged 4 commits into from
Sep 13, 2021

Conversation

dev7355608
Copy link
Collaborator

Description of change

Added the enabled property to MaskData to allow mask to be comfortably enabled/disabled without adding/removing the mask from the object.

Pre-Merge Checklist
  • Tests and/or benchmarks are included
  • Documentation is changed or added
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

bigtimebuddy
bigtimebuddy approved these changes Jul 31, 2021
View reviewed changes
Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is consistent with filters which also have an enabled property.

ShukantPal
ShukantPal approved these changes Jul 31, 2021
View reviewed changes
Copy link
Member

@ShukantPal ShukantPal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bigtimebuddy bigtimebuddy added this to the v6.2.0 milestone Aug 3, 2021
@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Sep 1, 2021
@bigtimebuddy bigtimebuddy merged commit ed0f855 into pixijs:dev Sep 13, 2021
@bigtimebuddy
Copy link
Member

Thanks @dev7355608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

@GoodBoyDigital GoodBoyDigital GoodBoyDigital approved these changes

@ShukantPal ShukantPal ShukantPal approved these changes

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
v6.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dev7355608 @bigtimebuddy @GoodBoyDigital @ShukantPal