Allow multiple objects to have the same mask #7754
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Multiple objects having the same mask is possible, but the code doesn't seem to be written with that in mind.
isMask
can easily end up being false even if the object is still used as a mask. The current implementation can cause problems if the mask object is before the object that is masked in the scene graph: the mask is rendered normally for one frame after isMask is set to false and renderable to true when the mask is removed from another object; isMask remains false, but renderable is set to false again by the mask system. Here a demo where the the mask is added and removed from some other object every frame and so the mask is rendered normally in the background. https://www.pixiplayground.com/#/edit/jC73hmNsD59Hgyp6kseVL. If the mask is after the all objects that use the mask in the scene graph, this visual bug wouldn't occur; onlyisMask
would be incorrectly false.I fixed this problem by adding a reference counter that counts the number of times the object is used as a mask.
Pre-Merge Checklist
npm run lint
)npm run test
)