Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat Transform.ts documentation #7787

Merged
merged 10 commits into from
Sep 20, 2021
Merged

Reformat Transform.ts documentation #7787

merged 10 commits into from
Sep 20, 2021

Conversation

ShukantPal
Copy link
Member

Description of change

#7159

@ShukantPal ShukantPal mentioned this pull request Sep 10, 2021
Closed
@bigtimebuddy
Copy link
Member

https://pixijs.download/chore/docs-math/docs/Transform.html

You need to also attach this to PIXI also Matrix needs @type {PIXI.Matrix} or it won't be linked.

@ShukantPal ShukantPal marked this pull request as draft September 11, 2021 02:34
@ShukantPal
Copy link
Member Author

@bigtimebuddy Let me fix that Matrix thing in webdoc - looks like the automatic symbol resolving only works for extends, implements right now.

This was referenced Sep 12, 2021
Merged
Merged
@ShukantPal ShukantPal marked this pull request as ready for review September 19, 2021 02:14
@ShukantPal
Copy link
Member Author

@bigtimebuddy Ready for review!

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Sep 20, 2021
@bigtimebuddy bigtimebuddy merged commit 10586bb into dev Sep 20, 2021
@bigtimebuddy bigtimebuddy deleted the chore/docs-math branch September 20, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

@Zyie Zyie Zyie approved these changes

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ShukantPal @bigtimebuddy @Zyie