Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat Circle.ts, Ellipse.ts documentation #7788

Merged
merged 7 commits into from
Sep 20, 2021

Conversation

ShukantPal
Copy link
Member

Description of change

#7159

@bigtimebuddy
Copy link
Member

Circle and Ellipse should be in PIXI namespace.

https://pixijs.download/chore/docs-Circle-Ellipse/docs/index.html

@ShukantPal ShukantPal marked this pull request as draft September 12, 2021 20:03
@ShukantPal ShukantPal marked this pull request as ready for review September 19, 2021 02:12
@ShukantPal
Copy link
Member Author

@bigtimebuddy Ready for review!

@bigtimebuddy
Copy link
Member

Still not right. Needs to be memberof not namespace. Please look at the output docs now there are three PIXI entries.

@ShukantPal
Copy link
Member Author

Foolish mistake from me @bigtimebuddy, fixed!

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Sep 20, 2021
@bigtimebuddy bigtimebuddy added this to the v6.2.0 milestone Sep 20, 2021
@bigtimebuddy bigtimebuddy merged commit ec95483 into dev Sep 20, 2021
@bigtimebuddy bigtimebuddy deleted the chore/docs-Circle-Ellipse branch September 20, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants