-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: TilingSprite gaps when mipmapping enabled #7792
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gaps are still visible to me on Android 9 with Webgl2 on the mobile version of the website, but not on the desktop mode of the website Gaps are gone on the PC 👍 |
ivanpopelyshev
approved these changes
Sep 13, 2021
@eXponenta It may be because I hardcoded the DPI to 2 in the reproduction, and your device's DPI is 2.5 |
GoodBoyDigital
approved these changes
Sep 20, 2021
bigtimebuddy
added
the
✅ Ready To Merge
Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
label
Sep 20, 2021
Thanks @ShukantPal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
✅ Ready To Merge
Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7625
Description of change
I added a comment in the issue describing the underlying problem. In this fix, I create two versions of the tiling sprite shader (leaving the "simple" variant alone):
texture2DLodEXT
is not available in WebGL 2. Instead, I usetexture
with a very negative LOD-bias when sampling at the boundary of the tiled texture.Please see this reproduction and test whether the issue remains.