Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to webdoc 1.5.4 to fix getter-setter data-type inference #7809

Merged
merged 2 commits into from
Sep 23, 2021
Merged

Upgrade to webdoc 1.5.4 to fix getter-setter data-type inference #7809

merged 2 commits into from
Sep 23, 2021

Conversation

ShukantPal
Copy link
Member

@ShukantPal ShukantPal changed the title Sprite width, height getters don't need @member anymore Upgrade to webdoc 1.5.4 to fix getter-setter data-type inference Sep 19, 2021
This was referenced Sep 20, 2021
Merged
Merged
bigtimebuddy
bigtimebuddy requested changes Sep 20, 2021
View reviewed changes
Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Template dep needs to be updated here too. Currently its still ^1.3.3 and source links are still broken.

@ShukantPal
Copy link
Member Author

@bigtimebuddy there's another pr to fix source links that upgrades the template

@bigtimebuddy
Copy link
Member

Where is that PR?

@bigtimebuddy bigtimebuddy added this to the v6.2.0 milestone Sep 20, 2021
@ShukantPal
Copy link
Member Author

@bigtimebuddy It was #7801. I closed that due to a misreading on my part.

@bigtimebuddy bigtimebuddy requested a review from a team September 21, 2021 16:21
@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Sep 22, 2021
@bigtimebuddy bigtimebuddy merged commit f5d5611 into dev Sep 23, 2021
@bigtimebuddy bigtimebuddy deleted the chore/upgrade-webdoc-1.5.4 branch September 23, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

@Zyie Zyie Zyie approved these changes

@ivanpopelyshev ivanpopelyshev Awaiting requested review from ivanpopelyshev

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
v6.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ShukantPal @bigtimebuddy @Zyie