Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uniforms sync generation of inactive null uniform #7824

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

dev7355608
Copy link
Collaborator

Description of change

Fixes inactive null/undefined uniforms breaking uniforms sync generation.

Playground: https://www.pixiplayground.com/#/edit/HGD9TE6ISB-5ePVIvQOF8

test is an inactive uniform that is assigned null, which breaks the uniforms sync generation:

Uncaught TypeError: group.uniforms[i] is null
    generateUniformsSync core.js:6941
    createSyncGroups core.js:9230
    syncUniforms core.js:9224
    syncUniformGroup core.js:9214
    bind core.js:9189
Pre-Merge Checklist
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Sep 27, 2021
@bigtimebuddy bigtimebuddy added this to the v6.2.0 milestone Sep 27, 2021
@bigtimebuddy bigtimebuddy merged commit 71a910e into pixijs:dev Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants