Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ParticleContainer type issues #7840

Merged
merged 1 commit into from
Oct 4, 2021
Merged

Fix ParticleContainer type issues #7840

merged 1 commit into from
Oct 4, 2021

Conversation

bigtimebuddy
Copy link
Member

Fixes #7839
Fixes #7838

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Oct 2, 2021
@bigtimebuddy bigtimebuddy merged commit 0c2978f into dev Oct 4, 2021
@bigtimebuddy bigtimebuddy deleted the fix/particle-container-types branch October 4, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShukantPal ShukantPal ShukantPal approved these changes

@Zyie Zyie Zyie approved these changes

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ParticleContainer.blendMode is typed as readonly ParticleContainer constructor typing is incorrect
3 participants
@bigtimebuddy @ShukantPal @Zyie