bugfix: [7854] Update SVG test when converting svg to base64 #7857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! One small thing, could you please make a test for this so we don't repeat this error again? |
|
@bigtimebuddy
|
bigtimebuddy
approved these changes
Oct 13, 2021
miltoncandelero
approved these changes
Oct 18, 2021
|
@zero41120 thank you for this bug fix and congrats on the bounty. Please submit your invoice here to claim the bounty. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
#7460 and its merge request #7478 suppose to fix loader loading SVG issue.
#7478 only fix the detection, but the conversion RegExp was not update accordingly.
This pull request uses the same RegExp when checking again in the SVG to base 64.
Pre-Merge Checklist
npm run lint)npm run test)