Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Change addChild() to require at least one DisplayObject argument #7868

Merged
merged 3 commits into from
Oct 18, 2021
Merged

Fix: Change addChild() to require at least one DisplayObject argument #7868

merged 3 commits into from
Oct 18, 2021

Conversation

ShukantPal
Copy link
Member

Fixes #7861

@ShukantPal ShukantPal marked this pull request as draft October 13, 2021 03:03
@ShukantPal ShukantPal marked this pull request as ready for review October 17, 2021 15:15
@ShukantPal ShukantPal requested a review from Zyie October 17, 2021 15:15
@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Oct 18, 2021
@bigtimebuddy
Copy link
Member

Screen Shot 2021-10-18 at 9 49 48 AM

Just verified that this checks out.

@bigtimebuddy bigtimebuddy merged commit 5c07f5d into dev Oct 18, 2021
@bigtimebuddy bigtimebuddy deleted the fix/container-add-child-type branch October 18, 2021 13:50
@bigtimebuddy bigtimebuddy mentioned this pull request Nov 1, 2021
Closed
bigtimebuddy added a commit that referenced this pull request Nov 2, 2021
@bigtimebuddy
Revert "Fix: Change addChild() to require at least one DisplayObject …
9c28e42 
…argument (#7868)"

This reverts commit 5c07f5d.
@bigtimebuddy bigtimebuddy mentioned this pull request Nov 2, 2021
Merged
bigtimebuddy added a commit that referenced this pull request Nov 4, 2021
@bigtimebuddy
Revert: Change addChild() to require at least one DisplayObject argum…
f1c18ad 
…ent (#7868) (#7945)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigtimebuddy bigtimebuddy bigtimebuddy approved these changes

@Zyie Zyie Zyie approved these changes

Assignees
No one assigned
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix type annotation of Container.addChildren
3 participants
@ShukantPal @bigtimebuddy @Zyie