Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render to an empty filter texture if the filter source frame does not intersect the current source frame #8091

Merged
merged 7 commits into from
Apr 29, 2022
Merged

Render to an empty filter texture if the filter source frame does not intersect the current source frame #8091

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e30b4a2
Add Rectangle.intersects to core math
dev7355608 Jan 6, 2022
617aee4
Optimize no autoFit filters
dev7355608 Jan 6, 2022
0dcc9c4
Set width and height of autofitted source frame to zero if empty
dev7355608 Jan 7, 2022
9c63fcc
Merge remote-tracking branch 'upstream/dev' into no-autofit-optimization
dev7355608 Feb 22, 2022
379557c
Merge branch 'dev' into no-autofit-optimization
bigtimebuddy Apr 11, 2022
485e564
Merge branch 'dev' into no-autofit-optimization
bigtimebuddy Apr 25, 2022
65a2ed6
Merge branch 'dev' into no-autofit-optimization
bigtimebuddy Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions packages/core/src/filters/FilterSystem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,20 +188,31 @@ export class FilterSystem implements ISystem

state.sourceFrame.pad(padding);

const sourceFrameProjected = this.tempRect.copyFrom(renderTextureSystem.sourceFrame);

// Project source frame into world space (if projection is applied)
if (renderer.projection.transform)
{
this.transformAABB(
tempMatrix.copyFrom(renderer.projection.transform).invert(),
sourceFrameProjected
);
}

if (autoFit)
{
const sourceFrameProjected = this.tempRect.copyFrom(renderTextureSystem.sourceFrame);
state.sourceFrame.fit(sourceFrameProjected);

// Project source frame into world space (if projection is applied)
if (renderer.projection.transform)
if (state.sourceFrame.width <= 0 || state.sourceFrame.height <= 0)
{
this.transformAABB(
tempMatrix.copyFrom(renderer.projection.transform).invert(),
sourceFrameProjected
);
state.sourceFrame.width = 0;
state.sourceFrame.height = 0;
}

state.sourceFrame.fit(sourceFrameProjected);
}
else if (!state.sourceFrame.intersects(sourceFrameProjected))
{
state.sourceFrame.width = 0;
state.sourceFrame.height = 0;
}

// Round sourceFrame in screen space based on render-texture.
Expand Down