hitArea can also be null (fixing #8212) #8213
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to be able to remove hitAreas again. Also, the default for hitArea is null, so this is now properly reflected in the type.
|
Nice! Could you also fix the events package hitArea too which does the same thing: packages/events/src/FederatedEventTarget.ts Events is our future replacement for interaction manager. |
andrewstart
approved these changes
Mar 4, 2022
bigtimebuddy
added
the
✅ Ready To Merge
|
Good one, thanks @mathiasbockwoldt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to be able to remove hitAreas again. Also, the default for hitArea is null, so this is now properly reflected in the type.
Description of change
Added possible type
nulltohitAreaofInteractiveTarget(that is extended byDisplayObject).Pre-Merge Checklist
npm run lint)npm run test)