Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rollup warning, ignore used node dependencies #8493

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Fix Rollup warning, ignore used node dependencies #8493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bundles/pixi.js-node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@
"gl": "^5.0.0",
"xml2js": "^0.4.23"
},
"nodeDependencies": ["fs", "path"],
"publishConfig": {
"access": "public"
},
Expand Down
4 changes: 3 additions & 1 deletion rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ async function main()
standalone,
version,
dependencies,
nodeDependencies,
peerDependencies,
// TODO: remove this in v7, along with the declaration in the package.json
// This is a temporary fix to skip transpiling on the @pixi/node package
Expand All @@ -137,7 +138,8 @@ async function main()

// Check for bundle folder
const external = Object.keys(dependencies || [])
.concat(Object.keys(peerDependencies || []));
.concat(Object.keys(peerDependencies || []))
.concat(nodeDependencies || []);
const basePath = path.relative(__dirname, pkg.dir);
const input = path.join(basePath, 'src/index.ts');
const freeze = false;
Expand Down