-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Update document for MIPMAP_TEXTURES and MIPMAP_MODES #8781
Conversation
@bigtimebuddy Do you think this change is OK for v6.x, or only for v7? |
Whenever we change default settings that could have some impact on users, I'd consider that breaking (similar to #7974). So I would say v7 for this. |
Hey @SuperSodaSea , thanks for the PR! What would be your thoughts around mipmaps being turned off by default for all textures rather than on? Just thinking about the memory bandwidth we could save people.. |
I'd agree with Mat on this one. The negative memory impact seems substantial enough to keep it as-is. For the original issue, the user has two very viable options:
|
That make sence. So should I keep the current default value |
There are numerous places in Pixi with defaults where we need to balance good rendering with fast performance. This is one of those places. I would vote to keep it as-is (POW2) since I think it's representative of the best practices for Pixi (eg using pow2 spritesheets) over arbitrary sized assets (background images, text). It may not be the best for all scenarios, but that's why we expose a global default and have a local mipmap option on BaseTexture to override per asset. |
OK, now I reverted the default value to |
Description of change
Some document update for
MIPMAP_TEXTURES
andMIPMAP_MODES
.Pre-Merge Checklist
npm run lint
)npm run test
)