Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add ESLint cache #8935

Merged
merged 1 commit into from Dec 6, 2022
Merged

Chore: Add ESLint cache #8935

merged 1 commit into from Dec 6, 2022

Conversation

Simon-He95
Copy link
Contributor

Description of change
Pre-Merge Checklist
  • Tests and/or benchmarks are included
  • Documentation is changed or added
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL eslint has a cache option!

# cold start
npm run lint  14.50s user 0.71s system 162% cpu 9.384 total

# warm start
npm run lint  0.84s user 0.17s system 117% cpu 0.859 total

Thank you @Simon-He95

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Dec 5, 2022
@SuperSodaSea SuperSodaSea changed the title chore: add eslintcache Chore: Add ESLint cache Dec 5, 2022
@bigtimebuddy bigtimebuddy merged commit 2c63c44 into pixijs:dev Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants