Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate @pixi/node bundle #9217

Merged
merged 3 commits into from Feb 28, 2023
Merged

Migrate @pixi/node bundle #9217

merged 3 commits into from Feb 28, 2023

Conversation

bigtimebuddy
Copy link
Member

This change re-homes the @pixi/node bundle to https://github.com/pixijs/node

There are a few reasons for this move:

  1. GitHub Actions is slightly slower because it requires extra dependencies and extras steps
  2. It's more difficult to npm install the pixijs repo locally without stubbing your toe on node bundle dependencies
  3. The adapter and extensions APIs are stable enough in v7 to support this move
  4. This would allow us to remove a handful of exceptions in our build system for the node bundle
  5. This bundle has a small audience (261 weekly downloads vs 121K for pixi.js) and probably not worth all the overhead of the above to justify the cost

@bigtimebuddy bigtimebuddy added this to the v7.2.0 milestone Feb 28, 2023
@bigtimebuddy bigtimebuddy requested a review from a team February 28, 2023 15:58
@bigtimebuddy
Copy link
Member Author

PR Build times:

  • 5m 14s
  • 5m 31s
  • 6m 40s
  • 5m 56s
  • 7m 51s

Average: 6m 14s

Previous Build times:

  • 7m 9s
  • 8m 17s
  • 7m 53s
  • 6m 0s
  • 6m 42s

Average: 7m 12s

So it's ~1 minute faster on GitHub Actions.

@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Feb 28, 2023
@bigtimebuddy bigtimebuddy merged commit 25d7721 into dev Feb 28, 2023
@bigtimebuddy bigtimebuddy deleted the chore/remove-node-bundle branch February 28, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants