-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add loadVideo LoaderParser #9314
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ac0f2ec:
|
I know this is a draft, but super useful PR. Were you planning to do any browser feature-detection if the formats were supported? For instance, Safari does't support ogv. |
Maybe we can add some |
Could we add the config option to load all video files with |
Yes, lets definitely do this 👍 |
Where are we on this @SuperSodaSea? |
Need #9376 |
@SuperSodaSea done |
It seems that |
@SuperSodaSea #9389 should fix that. |
Co-authored-by: dev7355608 <dev7355608@gmail.com>
@dev7355608 I added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe loadVideos
(plural) instead of loadVideo
would be more consistent with loadTextures
(plural).
I think |
Description of change
Add
loadVideo
LoaderParser to support loading MP4 (.mp4 /video/mp4
), WebM (.webm /video/webm
) and OGG (.ogv /video/ogg
) videos viaPIXI.Assets.load()
.Closes #9263.
TODO
detectMp4
,detectOgv
, anddetectWebm
#9376!)Pre-Merge Checklist
npm run lint
)npm run test
)