Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DepthResource #9344

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Remove DepthResource #9344

merged 1 commit into from
Apr 24, 2023

Conversation

dev7355608
Copy link
Collaborator

Description of change

DepthResource.upload is identical to BufferResource.upload making DepthResource the same as BufferResource. And new BaseTexture(new BufferResource(null)) is uploaded exactly like new BaseTexture(null) if I'm not mistaken.

DepthResource appears in the docs, but isn't exported (PIXI.DepthResource is undefined). We can therefore remove it.

Pre-Merge Checklist
  • Tests and/or benchmarks are included
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 4, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 45017cf:

Sandbox Source
pixi.js-sandbox Configuration

@bigtimebuddy bigtimebuddy added this to the v7.3.0 milestone Apr 19, 2023
@bigtimebuddy bigtimebuddy added the ✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t label Apr 19, 2023
@bigtimebuddy bigtimebuddy merged commit 5591e46 into dev Apr 24, 2023
@bigtimebuddy bigtimebuddy deleted the remove-DepthResource branch April 24, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Ready To Merge Helpful when issues are in the queue waiting to get merged. This means the PR is completed and has t
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants