fix: force strict check for group variable in UniformGroup #9454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aims to solve pixijs#9414 where safari invented the group method in arrays and that made it so arrays now were detected as UniformGroups
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c1bff66:
|
|
Nice fix. Could you add an inline comment about this? |
bigtimebuddy
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
LGTM, would like to @GoodBoyDigital to weigh-in as he understands the uniform stuff most deeply.
We have renamed this in v8, so this can be merged as is and avoid any breaking changes / deprecations |
Zyie
added
the
✅ Ready To Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This aims to solve #9414 where safari invented the group method in arrays and that made it so arrays now were detected as UniformGroups.
I achieved this by trying to find every place that a UniformGroup is used and where we check for the
groupvariable and forced an strict check with true. By doing this, truthy values are not enough, we must have that value set to true.I would like for somebody with more knowledge on UniformGroup code to see if I missed anything and if my solution makes sense.