Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with tiling texture #9708

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

GoodBoyDigital
Copy link
Member

@GoodBoyDigital GoodBoyDigital commented Sep 27, 2023

fixes #9706

πŸ€– Generated by Copilot at efba9dd

Summary

πŸ“ŠπŸ–ΌοΈπŸ”

This pull request improves the performance of texture binding and tiling sprite rendering in the pixijs library. It does this by avoiding unnecessary texture binding calls in GlTextureSystem.ts and redundant texture style updates in TilingSpritePipe.ts.

_boundTextures tracks
texture sources for each slot
less binding, more speed

Walkthrough

  • Optimize texture binding and style updates for tiling sprites (link, link)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit efba9dd:

Sandbox Source
pixi.js-sandbox Configuration

@Zyie Zyie added the v8 label Sep 27, 2023
@Zyie Zyie merged commit 851d7f7 into next-v8 Sep 27, 2023
4 checks passed
@Zyie Zyie deleted the bugfix/tiling-sprite-texture-style branch September 27, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants