Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8 Constructor Options #9710

Merged
merged 8 commits into from
Sep 28, 2023
Merged

v8 Constructor Options #9710

merged 8 commits into from
Sep 28, 2023

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented Sep 27, 2023

Adding first pass at constructor options for scene objects

const container = new Container({
  children: [
    new Sprite({
       texture: Texture.WHITE,
       tint: 'red',
       x: 100,
       y: 100,
       width: 200,
       height: 200,
       anchor: { x: 0.5, y: 0.5 },
       alpha: 0.8,
    })
  ]
});

example: https://codesandbox.io/s/pixi-js-sandbox-forked-dpl4f9?file=/index.js

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 27, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c4080e8:

Sandbox Source
pixi.js-sandbox Configuration
pixi.js-sandbox (forked) PR

@Zyie Zyie added the v8 label Sep 27, 2023
@Zyie Zyie added this to the v8.0.0-beta.2 milestone Sep 27, 2023
Copy link
Member

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! left a couple of comments

src/scene/container/Container.ts Outdated Show resolved Hide resolved
src/scene/container/Container.ts Outdated Show resolved Hide resolved
src/scene/container/Container.ts Outdated Show resolved Hide resolved
src/scene/container/Container.ts Outdated Show resolved Hide resolved
src/scene/container/Container.ts Show resolved Hide resolved
@Zyie Zyie merged commit 5e2db78 into next-v8 Sep 28, 2023
3 checks passed
@Zyie Zyie deleted the feature/v8-constrcutor-otions branch September 28, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants