Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passive interaction #9722

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fix passive interaction #9722

merged 1 commit into from
Sep 29, 2023

Conversation

Zyie
Copy link
Member

@Zyie Zyie commented Sep 29, 2023

removed the passive check in testHitFn as it is incorrect

we don't care if it is passive or not if the parent is interactive and we already do this check in the recursive functions

this is also an issue in v7, so will look to back port this

@Zyie Zyie added the v8 label Sep 29, 2023
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a8912f9:

Sandbox Source
pixi.js-sandbox Configuration

@Zyie Zyie added this to the v8.0.0-beta.2 milestone Sep 29, 2023
@bigtimebuddy
Copy link
Member

Backport welcome

@GoodBoyDigital GoodBoyDigital merged commit 60c6b30 into next-v8 Sep 29, 2023
3 checks passed
@GoodBoyDigital GoodBoyDigital deleted the fix/passive-interaction branch September 29, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants