Fix SVG path parsing logic to close paths properly #9764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 60bbee0:
|
achamas-playco
commented
Oct 18, 2023
|
|
||
| // TODO optimise and cache the paths? | ||
| export function SVGToGraphicsPath(svgPath: string, path: GraphicsPath): GraphicsPath | ||
| { | ||
| // get commands removing spaces at the end |
There was a problem hiding this comment.
This whole command parsing section basically got replaced with the 3rd party lib which is more robust and tested.
achamas-playco
force-pushed
the
fix-svg
branch
from
64355cf
to
749f06b
Compare
achamas-playco
commented
Oct 18, 2023
| break; | ||
| case 'Z': | ||
| case 'z': | ||
| path.closePath(); | ||
| if (subpaths.length > 0) |
There was a problem hiding this comment.
This is the key to fixing the original bug. SVG spec describes when a path is closed that the current pen position moves to where the last subpaths starting position was, which is why we need to track the subpaths as they're started/ended.
GoodBoyDigital
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 Generated by Copilot at 3e56a29
Summary
馃摝馃帹馃悰
This pull request improves the support for rendering SVG graphics in PixiJS. It refactors and fixes the
SVGToGraphicsPathfunction, adds a new dependencyparse-svg-pathto simplify the parsing of SVG paths, and adds a new test scene filesvg.scene.tsto demonstrate and verify the functionality.Walkthrough
parse-svg-pathdependency to parse SVG path commands (link)parsefunction (link, link, link)svg.scene.tsto render SVG graphic of PixiJS and JS logo usingGraphics.svgmethod (link)