Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: adapt KTXWorker messageHandlers #9784

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

YunYouJun
Copy link
Contributor

Description of change

KTXWorker onmessage listen is global, some tools like vite also send message type: 'messsage'.
We should be compatible for it.

image

image
image

messageHandlers[message] will be undefined.

image

Pre-Merge Checklist
  • Tests and/or benchmarks are included
  • Documentation is changed or added
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 49288c0:

Sandbox Source
pixi.js-sandbox Configuration

Copy link
Member

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch! 👍

@Zyie Zyie merged commit c327e78 into pixijs:next-v8 Oct 27, 2023
2 checks passed
@Zyie Zyie added the v8 label Oct 27, 2023
@YunYouJun YunYouJun deleted the next-v8 branch November 2, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants