add asset tests #9802
add asset tests #9802
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4a7e33b:
|
achamas-playco
force-pushed
the
chore/v8-tests-assets
branch
from
0051a84
to
c65c4d7
Compare
src/assets/resolver/Resolver.ts
Outdated
| // note: if the key is "format" and there are query params, | ||
| // then "format" will contain the query params as well, | ||
| // so we check inclusion rather than strict equality | ||
| return typeof priorityValue === 'string' |
There was a problem hiding this comment.
I think it would be better to fix the format? It should ideally be stripped of query params before it gets to here? cc @Zyie does that sound about right?
There was a problem hiding this comment.
yeah format shouldn't have a query param on it
There was a problem hiding this comment.
Ok wasn't sure if that was intended behavior so didn't change current state. Will fix.
There was a problem hiding this comment.
Fixed, moved extension parsing to small util function, tested that. Reverted bug workaround.
🤖 Generated by Copilot at 132ea06
Summary
🐛🚚✅
This pull request adds and updates unit tests for the
Assets,Cache, andLoaderclasses, and fixes a bug in theResolverclass. It also refactors some of the test files and utility functions to improve readability and avoid duplication. The main files affected aretests/assets/*.tests.ts,tests/utils/async.ts,src/assets/resolver/Resolver.ts, andtests/app/Application.tests.ts.Walkthrough
Resolverclass for assets with query parameters (link)tests/utils/async.tsand update import paths (link, link, link)basePathconstant totests/assets/basePath.tsand update import paths (link, link)Assetsclass related to asset bundles, video assets, detection parsers, and unresolved assets (link, link, link, link)Cacheclass related to custom parsers (link)Loaderclass related to loading and unloading different types of assets (link)loadWebFontfunction related to loading and unloading web fonts (link)createStringVariationsfunction related to generating string variations from template strings (link)tests/assets/sampleManifest.tsfor testing asset bundles (link)