Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix premultiply alpha issue with the white texture #9806

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

GoodBoyDigital
Copy link
Member

@GoodBoyDigital GoodBoyDigital commented Oct 30, 2023

馃 Generated by Copilot at a2150f0

Summary

馃帹馃И馃悰

The pull request fixes the alpha mode of texture.WHITE and ImageSource to be consistent with other textures and avoid rendering artifacts. It also adds a test case to check the alpha mode of texture.WHITE.

alpha mode set
to avoid artifacts, blend
texture test added

Walkthrough

  • Set the alpha mode of image sources to 'premultiply-alpha-on-upload' to avoid rendering artifacts (link)
  • Add a test case to check that texture.WHITE has the same alpha mode as other image sources (link)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a2150f0:

Sandbox Source
pixi.js-sandbox Configuration

@Zyie Zyie merged commit 4408f01 into next-v8 Oct 30, 2023
4 checks passed
@Zyie Zyie deleted the bugfix/v8/premultply-white-texture branch October 30, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants