Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8 rename BitmapFont parsers #9834

Merged
merged 3 commits into from
Nov 2, 2023
Merged

v8 rename BitmapFont parsers #9834

merged 3 commits into from
Nov 2, 2023

Conversation

GoodBoyDigital
Copy link
Member

@GoodBoyDigital GoodBoyDigital commented Nov 2, 2023

馃 Generated by Copilot at 34d435b

Summary

馃摑馃悰馃И

This pull request refactors and renames several modules related to bitmap font parsing and loading. It also adds a suffix to the font family key for bitmap fonts to avoid conflicts with canvas fonts. It fixes a bug where bitmap fonts would not render correctly in some cases. It adds a new test scene to demonstrate and verify the bitmap text feature.

We are the parsers of the bitmap font
We break the data into glyphs and kerns
We add the suffix to the font key
We are the masters of the bitmap font

Walkthrough

  • Fix a bug where bitmap fonts would not render correctly if the same font family was used for canvas text by appending -bitmap to the font family key when fetching the font data from the cache (link, link, link, link)
  • Rename the modules that parse bitmap font data from different formats to clarify their purpose and scope and improve the readability and maintainability of the code (link, link, link)
  • Update the references to the renamed modules in the files that import and use them (link, link, link, link, link, link, link)
  • Add a new test scene that renders both canvas and bitmap text of the same style to demonstrate and verify the functionality and appearance of the bitmap text feature in tests/visual/scenes/text/bitmap-text.scene.ts (link)

Copy link

codesandbox-ci bot commented Nov 2, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 822419a:

Sandbox Source
pixi.js-sandbox Configuration

@Zyie Zyie merged commit cf95d0a into next-v8 Nov 2, 2023
3 checks passed
@Zyie Zyie deleted the chore/v8/text-parser-rename branch November 2, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants