Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink about colorSpaceGamma #254

Closed
0b5vr opened this issue Nov 21, 2019 · 1 comment · Fixed by #365
Closed

Rethink about colorSpaceGamma #254

0b5vr opened this issue Nov 21, 2019 · 1 comment · Fixed by #365
Assignees
@0b5vr
Labels
Breaking Change Choose wisely Refactor Cool code is cool

Comments

@0b5vr
Copy link
Contributor

0b5vr commented Nov 21, 2019

uh
@0b5vr 0b5vr added Breaking Change Choose wisely Refactor Cool code is cool labels Nov 21, 2019
@0b5vr 0b5vr self-assigned this Nov 21, 2019
@0b5vr
Copy link
Contributor Author

0b5vr commented Feb 26, 2020

We got a good opportunity to change this! : mrdoob/three.js#18127

I'm going to remove colorSpaceGamma from arguments of MToonMaterial and VRMMaterialImporter , and add a new argument encoding instead.

@0b5vr 0b5vr mentioned this issue Feb 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0b5vr 0b5vr

Labels
Breaking Change Choose wisely Refactor Cool code is cool
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support r112 encoding workflow pixiv/three-vrm
1 participant
@0b5vr