Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support r112 encoding workflow #365

Merged
merged 8 commits into from Feb 26, 2020
Merged

support r112 encoding workflow #365

merged 8 commits into from Feb 26, 2020

Conversation

0b5vr
Copy link
Contributor

@0b5vr 0b5vr commented Feb 26, 2020

Sequel of #358 , will resolve #254

Three.js now uses WebGLRenderer.outputEncoding: TextureEncoding instead of WebGLRenderer.gammaOutput: boolean so we're going to follow this way.

  • Removed colorSpaceGamma from arguments of MToonMaterial and VRMMaterialImporter
    • Added a new argument encoding for them instead.
      • The type is THREE.TextureEncoding

Ref:
mrdoob/three.js#18127
mrdoob/three.js#18108

@0b5vr 0b5vr added bug Something isn't working Breaking Change Choose wisely labels Feb 26, 2020
@0b5vr 0b5vr added this to the v0.3.0 milestone Feb 26, 2020
@0b5vr 0b5vr self-assigned this Feb 26, 2020
@0b5vr 0b5vr marked this pull request as ready for review February 26, 2020 15:49
@0b5vr 0b5vr merged commit 2e73a4d into dev Feb 26, 2020
@0b5vr 0b5vr deleted the encoding branch February 26, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@0b5vr 0b5vr

Labels
Breaking Change Choose wisely bug Something isn't working
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

Rethink about colorSpaceGamma
1 participant
@0b5vr