[1.0] Rename thumb bone names #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: vrm-c/vrm-specification#381 - `leftThumbProximal` -> `leftThumbMetacarpal` - `leftThumbIntermediate` -> `leftThumbProximal` - `rightThumbProximal` -> `rightThumbMetacarpal` - `rightThumbIntermediate` -> `rightThumbProximal` Compat for VRM0.0: just rename the bones Compat for VRM1.0-beta: if either `leftThumbIntermediate` or `rightThumbIntermediate` exists, rename the bones
maybe lint and test should depend on build results?
|
CIについて、lintジョブが他パッケージの型定義に依存していてfailしていたため、lintジョブ（とついでにtestジョブ）をbuildにdependantとしました。 言われてみればそれはそうという感じですが、逆になぜ今まで動いていたのがとても謎でございます。 |
|
親指の根本は中手骨なので名前を修正している |
ke456-png
approved these changes
Jul 4, 2022
0b5vr
added a commit
that referenced
this pull request
Jul 25, 2022
Thumb bones has been renamed in #1001
ke456-png
added a commit
that referenced
this pull request
Jul 29, 2022
#1001 - leftThumbProximal -> leftThumbMetacarpal - leftThumbIntermediate -> leftThumbProximal - rightThumbProximal -> rightThumbMetacarpal - rightThumbIntermediate -> rightThumbProximal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on vrm-c/vrm-specification#381 , the PR renames the names of thumb bones.
leftThumbProximal->leftThumbMetacarpalleftThumbIntermediate->leftThumbProximalrightThumbProximal->rightThumbMetacarpalrightThumbIntermediate->rightThumbProximalThis PR also contains: