Adjust animation with reference to hips height #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust with reference to waist height VRMのhipsの高さとmixamoのFBXのhipsのYの比によって、 hipsの位置のアニメーションの値を変更します。 これによって、足の長いVRMや短いVRMでも地面に足がついた状態でアニメーションするようになります。
ke456-png
commented
Oct 3, 2022
Comment on lines
+24
to
+28
| const motionHipsHeight = asset.getObjectByName( 'mixamorigHips' ).position.y; | ||
| const vrmHipsY = vrm.humanoid?.getNormalizedBoneNode( 'hips' ).getWorldPosition( _vec3 ).y; | ||
| const vrmRootY = vrm.scene.getWorldPosition( _vec3 ).y; | ||
| const vrmHipsHeight = Math.abs( vrmHipsY - vrmRootY ); | ||
| const hipsPositionScale = vrmHipsHeight / motionHipsHeight; |
There was a problem hiding this comment.
VRMは位置を変更している可能性があるためvrm.sceneとの差をとっています。
mixamoのFBXからはy座標をそのままとっています。
ke456-png
changed the title
0b5vr
reviewed
Oct 3, 2022
|
|
||
| tracks.push( new THREE.VectorKeyframeTrack( `${nodeName}.${propertyName}`, track.times, value ) ); | ||
| const value = track.values.map( ( v, i ) => ( vrm.meta?.metaVersion === '0' && i % 3 !== 1 ? - v : v ) * hipsPositionScale ); | ||
| tracks.push( new THREE.VectorKeyframeTrack( `${vrmNodeName}.${propertyName}`, track.times, value ) ); |
There was a problem hiding this comment.
ここの nodeName の変更はシンプルにわざわざ別変数にする意味がなかったということですかね
|
コード見る感じ良さそうです。動作確認してみます |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
examples/humanoidAniamtion でVRMごとの身長差を考慮するように修正します
VRMのhipsの高さとmixamoのFBXのhipsのYの比によって、
hipsの位置のアニメーションの値を変更します。
これによって、足の長いVRMや短いVRMでも地面に足がついた状態でアニメーションするようになります。