Fix: fix lookAt, rightEye did have wrong orientation #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turns out that it's an easy mistake, See the diff of VRMLookAtBoneApplier Also added a test addressing this case
ke456-png
approved these changes
Nov 4, 2022
| const rightEye = this.humanoid.getRawBoneNode('leftEye'); | ||
| const rightEye = this.humanoid.getRawBoneNode('rightEye'); |
There was a problem hiding this comment.
[MEMO]
右目と左目でレストの姿勢が違う場合に問題が発生していた。
ありそうなケースで言うと"より目"にしている場合などが考えられそうです。
Comment on lines
+147
to
+176
|
|
||
| describe('when leftEye and rightEye have different rest orientations', () => { | ||
| beforeEach(() => { | ||
| scene = new THREE.Scene(); | ||
|
|
||
| humanoid = createHumanoid(); | ||
| scene.add(humanoid.getRawBoneNode('hips')!); | ||
| humanoid.getRawBoneNode('rightEye')!.quaternion.copy(QUAT_Y_CCW90); | ||
|
|
||
| applier = createBoneApplier(humanoid); | ||
| }); | ||
|
|
||
| it('makes each eye look toward the specified angle', () => { | ||
| applier.applyYawPitch(15.0, 15.0); | ||
|
|
||
| const rawLeftEye = humanoid.getRawBoneNode('leftEye')!; | ||
| const rawRightEye = humanoid.getRawBoneNode('rightEye')!; | ||
|
|
||
| // saturate( angle / rangeMap.inputMaxValue ) * rangeMap.outputScale = saturate( 15 / 30 ) * 5 = 2.5 | ||
| const expectedLeft = new THREE.Quaternion() | ||
| .setFromEuler(new THREE.Euler(DEG2RAD * 2.5, DEG2RAD * 2.5, 0.0, 'YXZ')) | ||
| .multiply(QUAT_Y_CW90); | ||
| const expectedRight = new THREE.Quaternion() | ||
| .setFromEuler(new THREE.Euler(DEG2RAD * 2.5, DEG2RAD * 2.5, 0.0, 'YXZ')) | ||
| .multiply(QUAT_Y_CCW90); | ||
|
|
||
| expect(rawLeftEye.quaternion).toBeCloseToQuaternion(expectedLeft); | ||
| expect(rawRightEye.quaternion).toBeCloseToQuaternion(expectedRight); | ||
| }); | ||
| }); |
|
Thank you for the review. Will merge and publish next monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rightEye did have wrong orientation, fixed this.
It turns out that it's an easy mistake, See the diff of VRMLookAtBoneApplier.
Also added a test addressing this case.