Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump three r154 #1260

Merged
merged 5 commits into from
Aug 7, 2023
Merged

Bump three r154 #1260

merged 5 commits into from
Aug 7, 2023

Conversation

ke456-png
Copy link
Contributor

@ke456-png ke456-png commented Aug 4, 2023 •
edited

Description

@ke456-png ke456-png added this to the next milestone Aug 4, 2023
@ke456-png ke456-png self-assigned this Aug 4, 2023
ke456-png
ke456-png commented Aug 7, 2023
View reviewed changes
packages/three-vrm-materials-mtoon/src/shaders/mtoon.frag
#include <encodings_fragment>
#include <colorspace_fragment>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebGLRenderer
Rename encodings_fragment to colorspace_fragment. mrdoob/three.js#26206, mrdoob/three.js#26269
Rename output_fragment to opaque_fragment. mrdoob/three.js#26278

@ke456-png
Copy link
Contributor Author

WebXRManager
Revert getCamera() removal. mrdoob/three.js#26350

@ke456-png ke456-png merged commit 0430354 into dev Aug 7, 2023
6 checks passed
@ke456-png ke456-png deleted the bump-three-r154 branch August 7, 2023 08:50
@0b5vr
Copy link
Contributor

0b5vr commented Oct 6, 2023

It seems this PR breaks compatibility of <r153!

We will fix this later.

0b5vr added a commit that referenced this pull request Oct 11, 2023
@0b5vr
fix: Fix pre-r154 incompatibility
52017cb 
pre-r154 says `<colorspace_fragment>` is not defined

The change was introduced in #1260, 8f0441a

I just noticed that we still have several pre-r136 compats in our MToon implementation, what should we do...
@0b5vr 0b5vr mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ke456-png ke456-png

Labels
None yet
Projects
None yet
Milestone
v2.0.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ke456-png @0b5vr