Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Moving from webpack to rollup, attempt 2 #527

Merged
merged 16 commits into from
Feb 2, 2021
Merged

WIP: Moving from webpack to rollup, attempt 2 #527

merged 16 commits into from
Feb 2, 2021

Conversation

0b5vr
Copy link
Contributor

@0b5vr 0b5vr commented Nov 4, 2020

will close #502 , will close #144
Retry of #506

  • Changed the bundler, from webpack to rollup
  • 馃毃 .module.js is now esm instead of umd
  • Updated README and examples accordingly
  • In IIFE variant, VRM components are installed under THREE_VRM
    • Also be installed under THREE as previous

Need to check

@0b5vr 0b5vr added Breaking Change Choose wisely Refactor Cool code is cool labels Nov 4, 2020
@0b5vr 0b5vr added this to the esm milestone Nov 4, 2020
@0b5vr 0b5vr self-assigned this Nov 4, 2020
@0b5vr 0b5vr mentioned this pull request Nov 5, 2020
6 tasks
@0b5vr
Copy link
Contributor Author

0b5vr commented Nov 26, 2020

It seems we cannot drop iife and cjs output yet...... 馃槱

mrdoob/three.js#20568

@0b5vr 0b5vr mentioned this pull request Nov 26, 2020
9 tasks
@0b5vr 0b5vr mentioned this pull request Jan 28, 2021
3 tasks
@0b5vr 0b5vr merged commit 456140c into dev Feb 2, 2021
@0b5vr 0b5vr deleted the rollup-2 branch February 2, 2021 06:42
@0b5vr 0b5vr modified the milestones: esm, v0.6.0 Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Choose wisely Refactor Cool code is cool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESM README.md npm example's module usage is confusing
1 participant