Remove unnecessary vertices #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To address the issue that morph textures consumes gigantic amount of VRAM See: mrdoob/three.js#23095
|
We can finally arm ourselves with r133 VTF morph targets, which enables us to use 8 or more morphs at the same time. Shoutouts to perfect sync community |
nyamadan
requested changes
Jan 6, 2022
| let indexHead = 0; | ||
|
|
||
| for (let i = 0; i < originalIndexArray.length; i++) { | ||
| const originalIndex = originalIndexArray[i]; |
There was a problem hiding this comment.
メモ
この処理でindexの最大値が減る。そのため各種attributeの大きさを減る。
Co-authored-by: nyamadan <nyamadan@pixiv.com>
Co-authored-by: nyamadan <nyamadan@pixiv.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new utility function
VRMUtils.removeUnnecessaryVertices.This is to address the issue that morph textures consumes gigantic amount of VRAM.
See comments for more details.
I probably have to apply this also for the current v0.x stream.
See: mrdoob/three.js#23095
Points need review