Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (1.0, schema): fix signatures of extensions #942

Merged
merged 1 commit into from
Mar 10, 2022
Merged

fix (1.0, schema): fix signatures of extensions #942

merged 1 commit into from
Mar 10, 2022

Conversation

0b5vr
Copy link
Contributor

@0b5vr 0b5vr commented Mar 10, 2022

Description

Changed type signature of .extensions of gltf properties from { [key: string]: { [key: string]: any } } to { [name: string]: any } .

See: #934 (comment)

Points need review

  • I think it's obvious based on the previous discussion

@0b5vr 0b5vr added the types Get typed label Mar 10, 2022
@0b5vr 0b5vr added this to the VRM 1.0 milestone Mar 10, 2022
@0b5vr 0b5vr requested a review from nyamadan March 10, 2022 09:40
@0b5vr 0b5vr self-assigned this Mar 10, 2022
nyamadan
nyamadan approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@nyamadan nyamadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうです！

@0b5vr 0b5vr merged commit 8db6944 into 1.0 Mar 10, 2022
@0b5vr 0b5vr deleted the fix-type-extensions branch March 10, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyamadan nyamadan nyamadan approved these changes

Assignees

@0b5vr 0b5vr

Labels
types Get typed
Projects
None yet
Milestone
VRM 1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0b5vr @nyamadan