[1.0] BREAKING Update LookAt #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite angle math using RAD2DEG and DEG2RAD
… euler
- Add new accessors `yaw` and `pitch` to `VRMLookAt`
- Arguments of `VRMLookAtApplier.lookAt` has been changed
- `VRMLookAt.euler`
- `VRMLookAt._calcEuler` has been renamed to `VRMLookAt._updateYawPitchByPosition` considering its role
- `VRMLookAt` now uses its protected member `_needsUpdate` to check whether it should apply its yaw and pitch to its applier or not
- Be aware that yaw and pitch won't be applied until you call `update` !
- `apply` receives `yaw` and `pitch` - `lookAt` is preserved and receives `euler` but it's deprecated
… `VRMLookAt` - `_updateYawPitchByPosition` is removed and integrated to `lookAt`
Follow latest lookAt API
- yaw, pitch was not compatible between VRM0.0 and VRM1.0, I have to add `faceFront` to `VRMLookAtBoneApplier` - VRMLookAtHelper also needs `faceFront`, I added a function `getFaceFrontQuaternion` to `VRMLookAt` - `VRMLookAtBoneApplier` was not compatible with eye bones which have non-uniform rest rotation, I fixed this by considering the rest rotation of eye bones - I wanted to test new utility functions, setup jest for `three-vrm-core`
- `VRMLookAt.getEuler()` should be used instead
namely, `VRMLookAtApplier.lookAt()`
…MLookAt.autoUpdate` is `false`
0b5vr
commented
Apr 25, 2022
0b5vr
commented
Apr 25, 2022
| * @param vector The vector | ||
| * @returns A tuple contains two angles, `[ azimuth, altitude ]` | ||
| */ | ||
| export function calcAzimuthAltitude(vector: THREE.Vector3): [ azimuth: number, altitude: number ] { |
There was a problem hiding this comment.
0b5vr
commented
Apr 25, 2022
Comment on lines
133
to
137
| leftEye.quaternion | ||
| .copy(_quatB) | ||
| .premultiply(_quatA) | ||
| .premultiply(_quatB.invert()) | ||
| .multiply(this._restQuatLeftEye); |
There was a problem hiding this comment.
quatB^-1 * quatA * quatB * restQuatLeftEye
There was a problem hiding this comment.
なんでpremultiplyしたかっていうと、 _quatB.invert() を2回叩きたくなかったから……
There was a problem hiding this comment.
Suggested change
| leftEye.quaternion | |
| .copy(_quatB) | |
| .premultiply(_quatA) | |
| .premultiply(_quatB.invert()) | |
| .multiply(this._restQuatLeftEye); | |
| // quatB^-1 * quatA * quatB * restQuatLeftEye | |
| leftEye.quaternion | |
| .copy(_quatB) | |
| .premultiply(_quatA) | |
| .premultiply(_quatB.invert()) | |
| .multiply(this._restQuatLeftEye); |
0b5vr
commented
Apr 25, 2022
|
99d96fc : deprecatedにした |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are many changes in this PR.
I have added descriptions for each commit; you might want to see each in order.
The primary purpose of this PR is to make
VRMLookAtable to use manually setyawandpitch.yawandpitchmanually.yawandpitch(formerlyeuler).VRMLookAtBoneApplieris now compatible with eye bones witch have non-uniform rest rotations.VRMLookAtHelpernow works properly on VRM0.0.VRMLookAtHelpernow hides target gizmo whenVRMLookAt.autoUpdateisfalse.Breaking Changes
VRMLookAt.euleris deprecated. Useyawandpitch, orgetEuler()instead.VRMLookAt._calcEuler()is removed. UseVRMLookAt.lookAt()instead.VRMLookAtis now not applied to its applier immediately.VRMLookAthas its internal flag_needsUpdate, and it's applied when we call itsupdate()VRMLookAtApplier.lookAt()is deprecated. UseapplyYawPitch()instead.VRMLookAtBoneAppliernow requiresfaceFrontin order to use with VRM0.0 models.VRMLookAtLoaderPluginPoints need review