[1.0] bump three.js to r140 #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Confirmed that the fog feature is working properly See: mrdoob/three.js#23939 See: three-types/three-ts-types@cbe1967
using `Object.freeze` on Quaternion makes the quaternion type imcompatible because of iterator It seems to be a bug of TypeScript which is already fixed in the latest version See: microsoft/TypeScript#42543
0b5vr
force-pushed
the
1.0-bump-three-r140
branch
from
032b465
to
7a7e33e
Compare
nyamadan
reviewed
May 24, 2022
| const IDENTITY_MATRIX4 = Object.freeze(new THREE.Matrix4()); | ||
| const IDENTITY_QUATERNION = Object.freeze(new THREE.Quaternion()); | ||
| const IDENTITY_MATRIX4 = new THREE.Matrix4(); | ||
| const IDENTITY_QUATERNION = new THREE.Quaternion(); |
There was a problem hiding this comment.
特にexportもしてませんし、workaroundであれば私は許容できるという感想です。
nyamadan
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump Three.js to r140.
Description
.foghas been transferred to each subclass ofMaterial,MToonMaterialnow has its own.fogproperty.Object.freezewhich causes TypeScript type error.Points need review
Object.freeze?