Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certain size combinations do not resize correctly #20

Closed
sebduggan opened this issue Mar 28, 2020 · 1 comment
Closed

Certain size combinations do not resize correctly #20

sebduggan opened this issue Mar 28, 2020 · 1 comment
Assignees
@sebduggan
Labels
bug Something isn't working

Comments

@sebduggan
Copy link
Contributor

Certain combinations of sizes do not resize correctly, due to the combination of rounding in the extension and in the libvips library.

For example, given a source image of 752x726 pixels, certain widths will not resize correctly:

Target width 593 - actually resizes to 592
Target width 622 - actually resizes to 621
Target width 651 - actually resizes to 650
Target width 680 - actually resizes to 679

This in turn means that further cropping will not take place.
@sebduggan sebduggan added the bug Something isn't working label Mar 28, 2020
@sebduggan sebduggan self-assigned this Mar 28, 2020
sebduggan added a commit that referenced this issue Mar 28, 2020
@sebduggan
#20 Issue with dimension rounding and certain combinations of source/…
74df0c0 
…target sizes
@sebduggan
Copy link
Contributor Author

Fixed in v1.0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebduggan sebduggan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sebduggan