Feature/v4 post release fixes #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 27, 2024 08:07
…or uploaded datasets. Fixed some error handling too
…g read, and that image is a RGBU TIF, which failed to be read by Go tif lib. We now detect it's an RGBU TIF and use a hard-coded width/height
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| var img image.Image | ||
|
|
||
| if imageExt == ".IMG" { | ||
| w, h, d, err := imgFormat.ReadIMGFile(imgData) | ||
| imgWidth = uint32(w) |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types High
| var img image.Image | ||
|
|
||
| if imageExt == ".IMG" { | ||
| w, h, d, err := imgFormat.ReadIMGFile(imgData) | ||
| imgWidth = uint32(w) | ||
| imgHeight = uint32(h) |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types High
| @@ -656,19 +664,36 @@ | |||
| matchInfo *protos.ImageMatchTransform, | |||
| jobLog logger.ILogger) error { | |||
| // Read the image - we used to only copy files around but here we need to open it for meta data | |||
| imgFile, err := utils.ReadImageFile(imagePath) | |||
| imgbytes, err := os.ReadFile(imagePath) | |||
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.