-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add library to NPM #4
Comments
KeyshapeJS isn't intended to be a generic JavaScript animation library, so adding it to NPM may not be a good idea. |
~Fair point. Would you consider instead making the repo installable as a package with Just a suggestion. |
Any taughts on this suggestion? |
I can consider adding KeyshapeJS to NPM when the next version is released. |
Hi! Congratulations on the new release and features! The icon looks way better in my opinion as well..! So... |
I can try to publish KeyshapeJS to NPM, but I'm not sure how you want to use it. Should the package have the same files as the repository has? How do you plan to use them? |
It is just way more convenient to have a library as a npm dependency. It allows to keep a better eye on how much each external dependencies weights. I don't think the current structure of the lib would allow tree-shaking but that could be a way of improving things in the future. Why exactly do you have a reluctance to publish keyshapejs on npm, if you don't mind me asking? |
I can publish it on NPM. I'm trying to understand how the library will be used so that I can test it. Do you plan to use it in a React app? Do you plan to |
On my side I plan to use it as an |
KeyshapeJS has been published on NPM: https://www.npmjs.com/package/keyshapejs It can be imported and used like this:
It works with SVG inlined in HTML, but the library can't be used with SVG files loaded with |
No description provided.
The text was updated successfully, but these errors were encountered: