feat: Add input validation for gitURL and slug in POST /project endpoint #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeterrayt
commented
Feb 13, 2024
codeterrayt
commented
- Implemented validation to ensure gitURL is a valid GitHub URL
- Added validation to enforce proper format for the slug field, disallowing spaces
- Return appropriate error responses for invalid input formats
- Implemented validation to ensure gitURL is a valid GitHub URL - Added validation to enforce proper format for the slug field, disallowing spaces - Return appropriate error responses for invalid input formats
piyushgarg-dev
requested changes
Feb 14, 2024
- Updated the /project endpoint to generate a new slug if not provided - Resolves issue where endpoint previously returned an error response when slug was not present
Issue: Containers are still running piyushgarg-dev#7 added: process.exit(0) to exit
|
hey @piyushgarg-dev Please have a look at changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.